Java tinker sdk uses wrong post url

Ciatzo

https://github.com/bunq/tinker_java/blob/2b2d5f90f35496075f4abf9e81d9dd930cfafb8d/src/main/java/com/bunq/tinker/libs/BunqLib.java#L294

When creating a new sandbox user using the java tinker project, a "404 route not found" is always returned. This seems to be because the url used in the post request "https://public-api.sandbox.bunq.com/v1/sandbox-user" is not usable. The curl command provided in the documentation is "https://public-api.sandbox.bunq.com/v1/sandbox-user-person", and adding the "-person" to the tinker source fixes the 404 problem.

Bastiaan

Cian Hello!

Are you sure you’re using the latest version (0.12.0) which was released yesterday?

Ciatzo

Just downloaded the (presumably) newest version using "bash <(curl -s https://tinker.bunq.com/java/setup.sh)", problem persists. I would assume that the line i've linked to in the post is included in the release if its still on github as well.

Bastiaan

Cian that’s strange 🤔. Because it’s fixed here: https://github.com/bunq/tinker_java/commit/341787c86de284c012457a7e8b1992a00ec74b37

Ciatzo

Bastiaan Strange indeed. I suppose either the release installed from the curl command is outdated or the commit is not included in said release (or my cmd cached the curl response?). Either way you are aware of the problem which is the most important. Might be worth to try installing it on your end to verify it uses the latest version. Thanks anyhow.

Bastiaan

Cian I think it has to do with the Git branch that is checked out by the setup.sh script (master).

The master branch isn’t as up-to-date as the develop branch. I will forward this issue.

Ciatzo

Bastiaan Cool, seems like the right solution!

sqm

Hi, has this been fixed? Still getting the same error:
Exception in thread "main" com.bunq.sdk.exception.BunqException: Encountered error while retrieving new sandbox ApiKey. Error message {"Error":[{"error_description":"Route not found.","error_description_translated":"Route not found."}]} at com.bunq.tinker.libs.BunqLib.generateNewSandboxUser(BunqLib.java:312) at com.bunq.tinker.libs.BunqLib.setupContext(BunqLib.java:115) at com.bunq.tinker.libs.BunqLib.setupContext(BunqLib.java:106) at com.bunq.tinker.libs.BunqLib.<init>(BunqLib.java:98) at com.bunq.tinker.UserOverview.run(UserOverview.java:26) at com.bunq.tinker.utils.TinkerRunner.main(TinkerRunner.java:22)

Also, https://tinker.bunq.com/java/setup.sh still seems to checkout the master branch.